Imported FC5 Rs232 Bug

Please add any bug reports that require discussion here

Moderator: Benj

Forum rules
Only bug reports will be considered here. General questions should not be posted in this forum.
Post Reply
medelec35
Matrix Staff
Posts: 9520
Joined: Sat May 05, 2007 2:27 pm
Location: Northamptonshire, UK
Has thanked: 2585 times
Been thanked: 3815 times
Contact:

Imported FC5 Rs232 Bug

Post by medelec35 »

Loading V5 Flowchart that contains RS232 then RS232 will not work.
Reason is:
Initialise RS232 was introduced with V6, and unlike FC5,
RS232 will not work without this Initialise command.

When importing FC5 that contains RS232, then since Initialise was not required, then there will not be a RS232 Initialise imported so RS232 will not work until Initialise is added.

Would it be better to remove the requirement for Initialise like it was in FC5?
Otherwise RS232 Initialise component will have to be automatically generated and place at the beginning.
That sounds like a bit of a tough thing to do?
Martin

User avatar
JonnyW
Posts: 1230
Joined: Fri Oct 29, 2010 9:13 am
Location: Matrix Multimedia Ltd
Has thanked: 63 times
Been thanked: 290 times
Contact:

Re: Imported FC5 Rs232 Bug

Post by JonnyW »

Hi Martin.I think there is the ability in the upgrader to add macros to the start of Main for this reason. 'Initialise' was added firstly for consistency and secondly for reliability.

Consistency because all components that require initialisation have an initialisation call, unlike v5 where some did and some automatically do so. Reliability because there is no guarantee when auto-generating initialisation calls that they are done in a specific order, so if this needs to be the case (console needs to be init after RS232, or filesystem after disk drive, etc) the User has control.

It is just an addition to the upgrader.xml and hopefully this should work OK. I have added 'autoinit' to this attached file, but it is untested.
upgrade_data.xml
(171.19 KiB) Downloaded 285 times
If you drop this file into the 'plugins' folder of Flowcode, it may well fix the problem.

Jonny

medelec35
Matrix Staff
Posts: 9520
Joined: Sat May 05, 2007 2:27 pm
Location: Northamptonshire, UK
Has thanked: 2585 times
Been thanked: 3815 times
Contact:

Re: Imported FC5 Rs232 Bug

Post by medelec35 »

Thanks Jonny.
Replaced old upgrade_data.xml with one attached.
No component macro was added to the start of main.
Was worth a try though.
This is the FC5 file I'm inporting into FC6:
http://www.matrixmultimedia.com/mmforum ... p?id=10302
Martin

User avatar
JonnyW
Posts: 1230
Joined: Fri Oct 29, 2010 9:13 am
Location: Matrix Multimedia Ltd
Has thanked: 63 times
Been thanked: 290 times
Contact:

Re: Imported FC5 Rs232 Bug

Post by JonnyW »

Cheers, I'll take a look. That should work - maybe I've put it in the wrong RS232 or something like that or maybe there is a bug. Either way, I'll see about testing this properly, no reason for it to not work.

Jonny

medelec35
Matrix Staff
Posts: 9520
Joined: Sat May 05, 2007 2:27 pm
Location: Northamptonshire, UK
Has thanked: 2585 times
Been thanked: 3815 times
Contact:

Re: Imported FC5 Rs232 Bug

Post by medelec35 »

Hi Jonny,
It's a step closer, but not there yet.
This is now what appears in FC6 when RS232 is used in FC5:
Rs232 autoplace Initilise1.png
(1.33 KiB) Downloaded 4447 times
Martin
Martin

User avatar
JonnyW
Posts: 1230
Joined: Fri Oct 29, 2010 9:13 am
Location: Matrix Multimedia Ltd
Has thanked: 63 times
Been thanked: 290 times
Contact:

Re: Imported FC5 Rs232 Bug

Post by JonnyW »

Ah! @*!#! OK, that will be sorted asap.

Jonny

medelec35
Matrix Staff
Posts: 9520
Joined: Sat May 05, 2007 2:27 pm
Location: Northamptonshire, UK
Has thanked: 2585 times
Been thanked: 3815 times
Contact:

Re: Imported FC5 Rs232 Bug

Post by medelec35 »

Hi Jonny,
JonnyW wrote:Ah! @*!#! OK, that will be sorted asap.
With Patch 4:

It's not quite sorted yet:
Rs232 autoplace Initilise2.png
(1.19 KiB) Downloaded 4421 times
As you can see the double V5 has gone but since component shows _name instead of the name of Rs232 component, then Simulation etc still fails.
Martin

User avatar
JonnyW
Posts: 1230
Joined: Fri Oct 29, 2010 9:13 am
Location: Matrix Multimedia Ltd
Has thanked: 63 times
Been thanked: 290 times
Contact:

Re: Imported FC5 Rs232 Bug

Post by JonnyW »

Sorry. Its coming to the end of a very long day. Even bugs like this are difficult to fix.

I have tested this through to compilation now.

Jonny

medelec35
Matrix Staff
Posts: 9520
Joined: Sat May 05, 2007 2:27 pm
Location: Northamptonshire, UK
Has thanked: 2585 times
Been thanked: 3815 times
Contact:

Re: Imported FC5 Rs232 Bug

Post by medelec35 »

JonnyW wrote:Sorry. Its coming to the end of a very long day. Even bugs like this are difficult to fix.
Hi Jonny,
It's fine.
Since its in beta stage, I'm not posting because I need this sorting ASAP.
Only posting to help the development by testing,
It's understandable that it may take a few attempts to get things working the way they are intended to.
Martin

Post Reply